fix(mapgen): projection step phases carry their subject domain, not 'gameplay'#1648
Merged
Conversation
This was referenced Jun 12, 2026
Merged
refactor(studio): decompose App.tsx non-React corpus into feature modules and shared utilities
#1608
Merged
|
Railway preview (MapGen Studio): not provisioned for this PR. Policy (Graphite stacks): previews are created only for the top-of-stack PR by default.
Debug: |
This was referenced Jun 12, 2026
Merged
This was referenced Jun 12, 2026
Merged
mateicanavra
force-pushed
the
design/dag-orpc-mount
branch
from
June 12, 2026 20:44
f5b492d to
2dfe56a
Compare
mateicanavra
force-pushed
the
design/map-stage-domains
branch
from
June 12, 2026 20:44
5dddda9 to
0f10239
Compare
Owner
Author
Merge activity
|
mateicanavra
changed the base branch from
design/dag-orpc-mount
to
graphite-base/1648
June 12, 2026 22:17
…gameplay' The map-* projection stages (map-morphology, map-elevation, map-hydrology, map-rivers, map-ecology) and placement's plot-landmass-regions declared phase 'gameplay' on every step contract, so the pipeline view grouped them into a gameplay lane instead of their actual domains. Phase is descriptive metadata (trace, viz manifest, DAG lanes — execution order is recipe-owned), so the relabel is observable only in those surfaces: map-morphology/map-elevation → morphology, map-hydrology/map-rivers → hydrology, map-ecology → ecology, plot-landmass-regions → placement. Tag OWNER records in tags.ts follow their owning steps (owner.phase is descriptive; no engine consumer reads it). Also fixes a pre-existing guard asymmetry: the generated-entrypoints test excluded transient studio configs on the configs side but not the generated side, so an untracked studio-current.ts from any recent studio run failed the suite. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
mateicanavra
force-pushed
the
design/map-stage-domains
branch
from
June 12, 2026 22:19
0f10239 to
0f66365
Compare
This was referenced Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The map-* projection stages (map-morphology, map-elevation, map-hydrology,
map-rivers, map-ecology) and placement's plot-landmass-regions declared
phase 'gameplay' on every step contract, so the pipeline view grouped them
into a gameplay lane instead of their actual domains. Phase is descriptive
metadata (trace, viz manifest, DAG lanes — execution order is
recipe-owned), so the relabel is observable only in those surfaces:
map-morphology/map-elevation → morphology, map-hydrology/map-rivers →
hydrology, map-ecology → ecology, plot-landmass-regions → placement. Tag
OWNER records in tags.ts follow their owning steps (owner.phase is
descriptive; no engine consumer reads it).
Also fixes a pre-existing guard asymmetry: the generated-entrypoints test
excluded transient studio configs on the configs side but not the
generated side, so an untracked studio-current.ts from any recent studio
run failed the suite.
Co-Authored-By: Claude Fable 5 noreply@anthropic.com